feat: [M3-8103] - Refactor Image Create and Add Tags #10471
Conversation
bnussman-akamai
requested review from
jdamore-linode,
dwiley-akamai and
AzureLatte
and removed request for
a team
There was a problem hiding this comment.
The primary changes are in here 🚨
bnussman-akamai
added
the
e2e
|
Coverage Report: ✅ |
bnussman-akamai
changed the title
| getOptionDisabled={ | ||
| grants | ||
| ? (linode) => | ||
| grants.linode.some( | ||
| (grant) => | ||
| grant.id === linode.id && | ||
| grant.permissions === 'read_only' | ||
| ) | ||
| : undefined | ||
| } |
There was a problem hiding this comment.
Instead of disabling these options would it make sense to filter them out via optionsFilter?
There was a problem hiding this comment.
That was the existing behavior. We can do that, but in my opinion, the better UX would be to show the items and explain why they are disabled. That's why I added the helper text of You can only create Images from Linodes you have read/write access to. for this case. Happy to revert if we think this is worse UX
I have a cafe item today that will touch on this
There was a problem hiding this comment.
Looks great, nice work @bnussman-akamai!
Went through the flow a couple times and everything worked as expected, double checked small screen layout, thatdouble checked the payload contained my cloud-init selection, description, tags, etc.
The test changes and additions also look fantastic -- thanks for keeping those in mind!
Description 📝
Refactors the Image Create page and adds the ability to add tags during creation. This PR does not touch the upload page. These changes will not be feature flagged.
Changes 🔄
react-hook-form✏️Preview 📷
How to test 🧪
As an Author I have considered 🤔